qualified identifier #1411
Merged
qualified identifier #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (db1c85b) but now fail: 0 Number failing in Base (db1c85b) but now pass: 0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
============================================
+ Coverage 73.14% 73.16% +0.01%
Complexity 2393 2393
============================================
Files 247 247
Lines 17623 17627 +4
Branches 3176 3178 +2
============================================
+ Hits 12890 12896 +6
+ Misses 3856 3854 -2
Partials 877 877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rchowell
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
Backward compatible:
I don't think this PR is backward incompatible as the new AST carries the notion of qualified identifier, and uses the identifier as the output for CREATE TABLE and DROP TABLE node.
The grammar rule changes affected the generated Antlr Parser but no user should directly invoke the Antlr generated parser anyway (i.e., The Antlr generated parser should not be sem-ver-ed in my opinion.)
The Pig AST remains unmodified.
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Any backward-incompatible changes? [YES/NO]
Any new external dependencies? [YES/NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes.
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.